Updated dotIndex logic to accommodate ItemNames having Periods #1319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 19, 2023 15:52
… Duplicate Item Names with different MimeTypes.
AdamNaj
reviewed
Aug 8, 2025
There was a problem hiding this comment.
Hi Pavan,
The code seems to be doing much more than the PR review is advertising. I wonder if you could provide some more context as to what's happening and why?
Also,,, I am not sure if this logic should be needed - in Sitecore in general item names cannot contain dots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated dotIndex logic to accommodate ItemNames having Periods; Duplicate Item Names with different MimeTypes.